Hi Geert,
On Mon, Mar 31, 2025 at 4:48 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Mon, 31 Mar 2025 at 17:37, Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > On Mon, Mar 31, 2025 at 4:16 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > > On Thu, 27 Mar 2025 at 20:33, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > >
> > > > Enable various Renesas SoCs by default when ARCH_RENESAS is selected.
> > > > Adding default y if ARCH_RENESAS to the relevant configurations removes
> > > > the need to manually enable individual SoCs in defconfig files.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > >
> > > Thanks for your patch!
> > >
> > > > --- a/drivers/soc/renesas/Kconfig
> > > > +++ b/drivers/soc/renesas/Kconfig
> > > > @@ -65,17 +65,20 @@ if ARM && ARCH_RENESAS
> > >
> > > Note that this whole block already depends on ARCH_RENESAS...
> > > I forgot about the reason, but commit 8070ba6348608aa1 ("ARM: shmobile:
> > > fix build regressions") reminded me. This is also the reason why we
> > > cannot open the block for COMPILE_TEST in general.
> > >
> > > >
> > > > config ARCH_EMEV2
> > > > bool "ARM32 Platform support for Emma Mobile EV2"
> > > > + default y if ARCH_RENESAS
> > >
> > > ... so the "if ..." part is not really needed for arm32 SoCs.
> > >
> > Ok, got you.
> >
> > > > @@ -197,6 +216,7 @@ if ARM64
> > >
> > > Note that unlike on arm32, the arm64 (and riscv) block does not depend
> > > on ARCH_RENESAS, so the "if ARCH_RENESAS" part is needed.
> > To keep it consistent would you prefer `if ARM64 && ARCH_RENESAS` to
> > be added and then all of the SoCs can just have `default y
> > ARCH_RENESAS`.
>
> I am still undecided. On one side, I like symmetry; on the other side,
> I like opening up as much as possible for compile-testing.
>
> Note that apart from a scary "WARNING: unmet direct dependencies
> detected for PM", an m68k allmodconfig kernel builds fine after
>
> -if ARM64
> +if ARM64 || COMPILE_TEST
>
How about with the below:
diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index eb5bb6d36899..31f313d90f0a 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -122,7 +122,7 @@ menu "Kernel Features"
endmenu
-if !MMU
+if !MMU || COMPILE_TEST
menu "Power management options"
config PM
Cheers,
Prabhakar
