Re: [PATCH RFC INTERNAL v2 1/4] soc: renesas: Kconfig: Enable SoCs by default when ARCH_RENESAS is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prabhakar,

On Mon, 31 Mar 2025 at 21:09, Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> On Mon, Mar 31, 2025 at 4:48 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > Note that apart from a scary "WARNING: unmet direct dependencies
> > detected for PM", an m68k allmodconfig kernel builds fine after
> >
> >     -if ARM64
> >     +if ARM64 || COMPILE_TEST
> >
> How about with the below:
>
> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
> index eb5bb6d36899..31f313d90f0a 100644
> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -122,7 +122,7 @@ menu "Kernel Features"
>
>  endmenu
>
> -if !MMU
> +if !MMU || COMPILE_TEST
>  menu "Power management options"
>
>  config PM

I'd rather not add compile-testing for such a core subsystem symbol.
The SoC-specific ARCH_* symbols don't enable much code in-se, and mainly
expose driver options that become visible when compile-testing anyway.
I rather see build issues due to building the latter with PM disabled,
else we may lose the ability to notice such issues, and the opportunity
to fix them.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux