Re: [PATCH RFC INTERNAL v2 1/4] soc: renesas: Kconfig: Enable SoCs by default when ARCH_RENESAS is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prabhakar,

On Thu, 27 Mar 2025 at 20:33, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Enable various Renesas SoCs by default when ARCH_RENESAS is selected.
> Adding default y if ARCH_RENESAS to the relevant configurations removes
> the need to manually enable individual SoCs in defconfig files.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -65,17 +65,20 @@ if ARM && ARCH_RENESAS

Note that this whole block already depends on ARCH_RENESAS...
I forgot about the reason, but commit 8070ba6348608aa1 ("ARM: shmobile:
fix build regressions") reminded me.  This is also the reason why we
cannot open the block for COMPILE_TEST in general.

>
>  config ARCH_EMEV2
>         bool "ARM32 Platform support for Emma Mobile EV2"
> +       default y if ARCH_RENESAS

... so the "if ..." part is not really needed for arm32 SoCs.

> @@ -197,6 +216,7 @@ if ARM64

Note that unlike on arm32, the arm64 (and riscv) block does not depend
on ARCH_RENESAS, so the "if ARCH_RENESAS" part is needed.
In case anyone is wondering, on riscv we definitely don't want to
enable ARCH_R9A07G043 by default, as it depends on NONPORTABLE.

The general idea LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux