On Tue, 8 Apr 2025 at 17:07, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > The rather long function-names "mmc_can_poweroff_notify" (that will > > change to mmc_card_can_poweroff_notify with your series) and > > "mmc_host_can_poweroff_notify" are rather self-explanatory, don't you > > think? > > Well, you are the boss here, but frankly, I don't think it is obvious > enough. I had to look twice and very closely to understand the logic. > Not because of the function name, but for the reason why 'is_suspend' is > true despite being in _shutdown(). Adrian was wondering about it the > first time, too. So, I honestly think the comment is > > for a maintainer -> superfluous > for a part-time-MMC-core-hacker -> helpful to remember > for someone new to the code -> essential > > Something like this. > I understand what you are saying and I agree. However, the problem is that your concern applies to a lot more code in the mmc core, but this condition. Don't get me wrong, I don't mind useful comments and good documentation, but perhaps what we are really missing is a general mmc documentation that describes how the core is working and in particular the power-management part of it. Unfortunately, I don't think I will have the bandwidth currently to work on this. That said, I am going to apply the $subject patch as is - but feel free to send a patch on top if you want to add and improve any further comments in the code. I would be happy to apply it! Kind regards Uffe
