> The rather long function-names "mmc_can_poweroff_notify" (that will > change to mmc_card_can_poweroff_notify with your series) and > "mmc_host_can_poweroff_notify" are rather self-explanatory, don't you > think? Well, you are the boss here, but frankly, I don't think it is obvious enough. I had to look twice and very closely to understand the logic. Not because of the function name, but for the reason why 'is_suspend' is true despite being in _shutdown(). Adrian was wondering about it the first time, too. So, I honestly think the comment is for a maintainer -> superfluous for a part-time-MMC-core-hacker -> helpful to remember for someone new to the code -> essential Something like this.
Attachment:
signature.asc
Description: PGP signature
