On Wed, 6 Aug 2025 at 21:56, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Refactor the RZG2L pinctrl driver to support reuse of the common > rzg2l_read_oen() and rzg2l_write_oen() helpers across SoCs with > different output-enable (OEN) bit mappings. > > Introduce a new `pin_to_oen_bit` callback in `struct rzg2l_pinctrl_data` > to allow SoCs to provide custom logic for mapping a pin to its OEN bit. > Update the generic OEN read/write paths to use this callback when present. > > With this change, SoCs like RZ/G3S can reuse the common OEN handling > code by simply supplying their own `pin_to_oen_bit` implementation. > The previously duplicated `rzg3s_oen_read()` and `rzg3s_oen_write()` > functions are now removed. > > This improves maintainability and prepares the driver for supporting > future SoCs with minimal duplication. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > v2->v3: > - Added blank line after if condition in rzg2l_read_oen() and rzg2l_write_oen() > - Added Reviewed-by tag from Geert. Thanks, will queue in renesas-pinctrl for v6.18. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds