Hi, Geert, On 22.05.2025 18:26, Geert Uytterhoeven wrote: > Rename the to_mod_clock() helper macro to to_mstp_clock(), to match the > type of the returned structure. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > This depends on "[PATCH v2 3/8] clk: renesas: rzg2l-cpg: Add macro to > loop through module clocks" > https://lore.kernel.org/20250514090415.4098534-4-claudiu.beznea.uj@xxxxxxxxxxxxx, > > To be queued in renesas-clk for v6.17. > --- > drivers/clk/renesas/rzg2l-cpg.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c > index dc92f09d5616223b..9449a5a5714302f8 100644 > --- a/drivers/clk/renesas/rzg2l-cpg.c > +++ b/drivers/clk/renesas/rzg2l-cpg.c > @@ -1200,18 +1200,18 @@ struct mstp_clock { > bool enabled; > }; > > -#define to_mod_clock(_hw) container_of(_hw, struct mstp_clock, hw) > +#define to_mstp_clock(_hw) container_of(_hw, struct mstp_clock, hw) I don't know the history behind this, but, I think it should be the other way around for this driver, I mean change "mstp" strings with "mod"/"module". The RZ/G3S, RZ/G2L HW manuals mention "MSTP" string only as an abbreviation for "Module stop state". You can find "Module stop state (MSTP)" string on sections describing the MSTOP bits for individual modules. Instead, those manual refers to the clocks of individual IPs as "module clocks". The rzg2l-cpg.c is using "mod" for different module clock operations, e.g: - struct rzg2l_cpg_priv::num_mod_clks - rzg2l_mod_clock_endisable() - rzg2l_mod_clock_enable() - rzg2l_mod_clock_disable() - rzg2l_mod_clock_is_enabled() - static const struct clk_ops rzg2l_mod_clock_ops - rzg2l_mod_clock_get_sibling() - rzg2l_cpg_register_mod_clk() Also, the SoC specific drivers use "mod": - struct rzg2l_mod_clk - struct rzg2l_cpg_info::crit_mod_clks - struct rzg2l_cpg_info::num_crit_mod_clks - struct rzg2l_cpg_info::mod_clks - struct rzg2l_cpg_info::num_mod_clks - struct rzg2l_cpg_info::num_hw_mod_clks Other than this, if it "mstp" should remain, changes looks good to me and you can add my: Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> Thank you, Claudiu
