Hi Claudiu, On Fri, 23 May 2025 at 10:00, Claudiu Beznea <claudiu.beznea@xxxxxxxxx> wrote: > On 22.05.2025 18:26, Geert Uytterhoeven wrote: > > Rename the to_mod_clock() helper macro to to_mstp_clock(), to match the > > type of the returned structure. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > This depends on "[PATCH v2 3/8] clk: renesas: rzg2l-cpg: Add macro to > > loop through module clocks" > > https://lore.kernel.org/20250514090415.4098534-4-claudiu.beznea.uj@xxxxxxxxxxxxx, > > > > To be queued in renesas-clk for v6.17. > > --- > > drivers/clk/renesas/rzg2l-cpg.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c > > index dc92f09d5616223b..9449a5a5714302f8 100644 > > --- a/drivers/clk/renesas/rzg2l-cpg.c > > +++ b/drivers/clk/renesas/rzg2l-cpg.c > > @@ -1200,18 +1200,18 @@ struct mstp_clock { > > bool enabled; > > }; > > > > -#define to_mod_clock(_hw) container_of(_hw, struct mstp_clock, hw) > > +#define to_mstp_clock(_hw) container_of(_hw, struct mstp_clock, hw) > > I don't know the history behind this, but, I think it should be the other > way around for this driver, I mean change "mstp" strings with "mod"/"module". I considered that, too, until I saw: /** * struct mstp_clock - MSTP gating clock * > The RZ/G3S, RZ/G2L HW manuals mention "MSTP" string only as an abbreviation > for "Module stop state". You can find "Module stop state (MSTP)" string on > sections describing the MSTOP bits for individual modules. > > Instead, those manual refers to the clocks of individual IPs as "module > clocks". OK, to avoid confusion with the mstop registers, I better change it the other way around, and rename the comment to "struct mod_clock - Module clock". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
