Hi, Geert,
On 05.05.2025 18:53, Geert Uytterhoeven wrote:
> Hi Claudiu,
>
> On Thu, 10 Apr 2025 at 16:06, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
>> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>>
>> Move pointers at the beginning of structure definition to avoid padding,
>> if any.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/drivers/clk/renesas/rzg2l-cpg.c
>> +++ b/drivers/clk/renesas/rzg2l-cpg.c
>> @@ -1183,20 +1183,20 @@ rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
>> /**
>> * struct mstp_clock - MSTP gating clock
>> *
>> + * @priv: CPG/MSTP private data
>> + * @sibling: pointer to the other coupled clock
>> * @hw: handle between common and hardware-specific interfaces
>> * @off: register offset
>> * @bit: ON/MON bit
>> * @enabled: soft state of the clock, if it is coupled with another clock
>> - * @priv: CPG/MSTP private data
>> - * @sibling: pointer to the other coupled clock
>> */
>> struct mstp_clock {
>> + struct rzg2l_cpg_priv *priv;
>> + struct mstp_clock *sibling;
>
> I would move them below hw (which contains only pointers), so
> to_mod_clock() needs no calculations.
OK, I'll change it like this.
Thank you for your review,
Claudiu
