Hi Claudiu,
On Thu, 10 Apr 2025 at 16:06, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Move pointers at the beginning of structure definition to avoid padding,
> if any.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/clk/renesas/rzg2l-cpg.c
> +++ b/drivers/clk/renesas/rzg2l-cpg.c
> @@ -1183,20 +1183,20 @@ rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
> /**
> * struct mstp_clock - MSTP gating clock
> *
> + * @priv: CPG/MSTP private data
> + * @sibling: pointer to the other coupled clock
> * @hw: handle between common and hardware-specific interfaces
> * @off: register offset
> * @bit: ON/MON bit
> * @enabled: soft state of the clock, if it is coupled with another clock
> - * @priv: CPG/MSTP private data
> - * @sibling: pointer to the other coupled clock
> */
> struct mstp_clock {
> + struct rzg2l_cpg_priv *priv;
> + struct mstp_clock *sibling;
I would move them below hw (which contains only pointers), so
to_mod_clock() needs no calculations.
> struct clk_hw hw;
> u16 off;
> u8 bit;
> bool enabled;
> - struct rzg2l_cpg_priv *priv;
> - struct mstp_clock *sibling;
> };
>
> #define to_mod_clock(_hw) container_of(_hw, struct mstp_clock, hw)
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
