Re: [PATCH 3/3] rtc: rzn1: support input frequencies other than 32768Hz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 11, 2025 at 08:39:49AM +0200, Wolfram Sang wrote:
> 
> > > >     if (rate < RTCA0SCMP_MIN || rate > FIELD_MAX(RTCA0SCMP_MASK) + 1)
> > > >
> > > > ?
> > >
> > > You really think this is more readable than the original code? I am
> > > really tired of bike-shedding so I don't care much, but I do wonder...
> > 
> > I don't mind the literal 32000, but the "> BIT(22)" looks rather
> > obscure, IMO.
> 
> Really? Ok, then it is up to what Alexandre prefers, I guess...

Alexandre, what is your preference? Everything else has been sorted out
by now AFAICS...

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux