Hi ALOK > > + irq = platform_get_irq(pdev, 0); > > + if (irq <= 0) > > + return -ENODEV; > > nit: -EINVAL will be more relevant here > > > + > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENODEV; > > nit: not sure why -ENOMEM not return Thanks. Will fix in v4 Best regards --- Kuninori Morimoto