Re: [PATCH v3 02/10] spi: sh-msiof: use dev in sh_msiof_spi_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

> > sh_msiof_spi_probe() is using priv->dev everywhare,
> 
> everywhere

Grr, thank you for pointing it.

> > -       ret = devm_request_irq(&pdev->dev, i, sh_msiof_spi_irq, 0,
> > -                              dev_name(&pdev->dev), p);
> > +       ret = devm_request_irq(dev, i, sh_msiof_spi_irq, 0, dev_name(&pdev->dev), p);
> 
> Looks like you missed one instance ;-)

Because it can be 1 line now.

> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thanks


Thank you for your help !!

Best regards
---
Kuninori Morimoto




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux