Hi Geert > > sh_msiof_spi_probe() is using priv->dev everywhare, > > everywhere Grr, thank you for pointing it. > > - ret = devm_request_irq(&pdev->dev, i, sh_msiof_spi_irq, 0, > > - dev_name(&pdev->dev), p); > > + ret = devm_request_irq(dev, i, sh_msiof_spi_irq, 0, dev_name(&pdev->dev), p); > > Looks like you missed one instance ;-) Because it can be 1 line now. > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks Thank you for your help !! Best regards --- Kuninori Morimoto