Hi Geert Thank you for your review > > + # "MSIOF-SPI" specific > > + - if: > > + properties: > > + $nodename: > > + pattern: '^spi@' > > This condition does not match what you wrote in the cover letter: > the controller is used in I2S mode when a port(s) subnode is present, > and in SPI mode when no port(s) subnode is present. > > > + then: > > + allOf: > > + - $ref: spi-controller.yaml# > > Documentation/devicetree/bindings/spi/spi-controller.yaml indeed > requires that the node-name matches "^spi(@.*|-([0-9]|[1-9][0-9]+))?$". > The controller's node is located in the SoC-specific .dtsi, where its > intended use case is not yet known, and its node name cannot easily be > overridden in the board .dts that specifies the use case. Hence the > node name must always be "spi" (and cannot be e.g. "serial-engine"). > Let's hope there is no other use case for MSIOF that requires using > a different node name... Hmm... OK So what we can do is keep spi@xxx node name, and check whether it has Of-Graph, and select spi-controller.yaml Thank you for your help !! Best regards --- Kuninori Morimoto
