Hi, On Wed, Apr 16, 2025 at 12:04 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > > > Hi ALOK > > > > + irq = platform_get_irq(pdev, 0); > > > + if (irq <= 0) > > > + return -ENODEV; > > > > nit: -EINVAL will be more relevant here This is not a right suggestion, please return back irq so the error gets propagated. (Alok please read upto date documentation prior to any suggestions, this is the third patch where I'm noticing wrong suggestions). Cheers, Prabhakar > > > > > + > > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > > + if (!priv) > > > + return -ENODEV; > > > > nit: not sure why -ENOMEM not return > > Thanks. Will fix in v4 > > Best regards > --- > Kuninori Morimoto >
