On Sat, Mar 29, 2025, at 09:00, Biju Das wrote:
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 6824131b69b1..f62e436b1d4f 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -692,6 +692,7 @@ config MMC_SDHI
> tristate "Renesas SDHI SD/SDIO controller support"
> depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
> select MMC_TMIO_CORE
> + select REGULATOR if ARCH_RENESAS
> select RESET_CONTROLLER if ARCH_RENESAS
You should never 'select' another subsystem from a device
driver, that just causes circular dependencies leads to
unintended effects when a subsystem suddenly gets turned on
during 'make oldconfig' or 'make defconfig' when it should
have remained disabled.
I see that I forgot to send a patch I made when the problem
showed up two weeks ago, I'll send my patch.
Arnd
