Hi Biju,
On Sat, 29 Mar 2025 at 09:00, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> The driver no longer builds when regulator support is unavailable. Fix
> the build error undefined reference to rdev_get_drvdata() by selecting the
> REGULATOR in config MMC_SDHI.
>
> Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503290554.zASQT70Q-lkp@xxxxxxxxx/
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> * Added 'if ARCH_RENESAS' to leave SUPERH out
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 6824131b69b1..f62e436b1d4f 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -692,6 +692,7 @@ config MMC_SDHI
> tristate "Renesas SDHI SD/SDIO controller support"
> depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
> select MMC_TMIO_CORE
> + select REGULATOR if ARCH_RENESAS
Regardless of Arnd's comment, making the select optional means the
build can still break when compile-testing on a non-Reneas platform.
> select RESET_CONTROLLER if ARCH_RENESAS
> help
> This provides support for the SDHI SD/SDIO controller found in
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
