Hi Prabhakar,
On Mon, 18 Aug 2025 at 15:44, Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> On Mon, Aug 18, 2025 at 2:34 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > On Tue, 12 Aug 2025 at 22:03, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > >
> > > Add pinctrl node to RZ/N2H ("R9A09G087") SoC DTSI.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> > > @@ -5,6 +5,17 @@
> > > * Copyright (C) 2025 Renesas Electronics Corp.
> > > */
> > >
> > > +#define RZN2H_PINS_PER_PORT 8
> > > +
> > > +/*
> > > + * Create the pin index from its bank and position numbers and store in
> > > + * the upper 16 bits the alternate function identifier
> > > + */
> > > +#define RZN2H_PORT_PINMUX(b, p, f) ((b) * RZN2H_PINS_PER_PORT + (p) | ((f) << 16))
> > > +
> > > +/* Convert a port and pin label to its global pin index */
> > > +#define RZN2H_GPIO(port, pin) ((port) * RZN2H_PINS_PER_PORT + (pin))
> >
> > Shouldn't this be in a header file under include/dt-bindings/pinctrl/?
>
> Agreed, theT2H related macros are used in the driver whereas the above
> aren't. In the past DT maintainers opposed including such headers
> which aren't used in the DT and drivers. Hence I choose this approach.
> Please let me know if you want me to move this into a header file
> under dt-bindings.
We need to share the definitions between DT sources and DT overlay
sources, so that sounds like a convincing argument for a header file
to me.
Now, as RZT2H_PORT_PINMUX() must be identical to RZN2H_PORT_PINMUX(),
this could be the existing
<dt-bindings/pinctrl/renesas,r9a09g077-pinctrl.h> file
(cfr. my comment on [PATCH 07/13]).
> > Else you have to duplicate these definitions in DT overlays.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
