Hi Prabhakar,
On Tue, 12 Aug 2025 at 22:04, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Enable SD card slot which is connected to SDHI0 on the RZ/T2H and
> RZ/N2H EVKs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> @@ -104,6 +116,35 @@ sd0-emmc-ctrl-pins {
> };
> };
>
> +#if SD0_SD
> + sdhi0-pwen-hog {
> + gpio-hog;
> + gpios = <RZT2H_GPIO(2, 5) GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "SD0_PWEN";
> + };
> +#endif
> +
> + sdhi0_sd_pins: sd0-sd-group {
> + sd0-sd-data-pins {
No need for repeated sd0-sd-prefixes in the subnodes.
> + pinmux = <RZT2H_PORT_PINMUX(12, 2, 0x29)>, /* SD0_DATA0 */
> + <RZT2H_PORT_PINMUX(12, 3, 0x29)>, /* SD0_DATA1 */
> + <RZT2H_PORT_PINMUX(12, 4, 0x29)>, /* SD0_DATA2 */
> + <RZT2H_PORT_PINMUX(12, 5, 0x29)>, /* SD0_DATA3 */
> + <RZT2H_PORT_PINMUX(12, 6, 0x29)>, /* SD0_DATA4 */
> + <RZT2H_PORT_PINMUX(12, 7, 0x29)>, /* SD0_DATA5 */
> + <RZT2H_PORT_PINMUX(13, 0, 0x29)>, /* SD0_DATA6 */
> + <RZT2H_PORT_PINMUX(13, 1, 0x29)>; /* SD0_DATA7 */
> + };
SDcard uses only DATA0-3?
> +
> + sd0-sd-ctrl-pins {
> + pinmux = <RZT2H_PORT_PINMUX(12, 0, 0x29)>, /* SD0_CLK */
> + <RZT2H_PORT_PINMUX(12, 1, 0x29)>, /* SD0_CMD */
> + <RZT2H_PORT_PINMUX(22, 5, 0x29)>, /* SD0_CD */
> + <RZT2H_PORT_PINMUX(22, 6, 0x29)>; /* SD0_WP */
> + };
> + };
> +
> #if SD1_MICRO_SD
> sdhi1-pwen-hog {
> gpio-hog;
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
