Hi Geert,
Thank you for the review.
On Mon, Aug 18, 2025 at 2:34 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 22:03, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Add pinctrl node to RZ/N2H ("R9A09G087") SoC DTSI.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g087.dtsi
> > @@ -5,6 +5,17 @@
> > * Copyright (C) 2025 Renesas Electronics Corp.
> > */
> >
> > +#define RZN2H_PINS_PER_PORT 8
> > +
> > +/*
> > + * Create the pin index from its bank and position numbers and store in
> > + * the upper 16 bits the alternate function identifier
> > + */
> > +#define RZN2H_PORT_PINMUX(b, p, f) ((b) * RZN2H_PINS_PER_PORT + (p) | ((f) << 16))
> > +
> > +/* Convert a port and pin label to its global pin index */
> > +#define RZN2H_GPIO(port, pin) ((port) * RZN2H_PINS_PER_PORT + (pin))
>
> Shouldn't this be in a header file under include/dt-bindings/pinctrl/?
Agreed, theT2H related macros are used in the driver whereas the above
aren't. In the past DT maintainers opposed including such headers
which aren't used in the DT and drivers. Hence I choose this approach.
Please let me know if you want me to move this into a header file
under dt-bindings.
> Else you have to duplicate these definitions in DT overlays.
>
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
Cheers,
Prabhakar
