Hi Geert,
Thank you for the review.
On Mon, Aug 18, 2025 at 3:00 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 22:03, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Enable I2C0 and I2C1 on the RZ/N2H evaluation board.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dts
>
> > + /*
> > + * I2C1 Pin Configuration:
> > + * ------------------------
> > + * Signal | Pin | DSW7
> > + * -------|---------|--------------
> > + * SCL | P03_3 | 3: ON, 4: OFF
>
> 1: ON, 2: OFF
>
> > + * SDA | P03_4 | 1: ON, 2: OFF
>
> 3: ON, 4: OFF
>
Agreed, I will fix it in v2.
Cheers,
Prabhakar
> > + */
> > + i2c1_pins: i2c1-pins {
> > + pinmux = <RZN2H_PORT_PINMUX(3, 3, 0x17)>,
> > + <RZN2H_PORT_PINMUX(3, 4, 0x17)>;
> > + };
> > +};
>
> The rest LGTM.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
