On Fri, 8 Aug 2025 at 15:30, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx> > > Add the pinctrl and gpio driver for RZ/T2H > > Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx> > Co-developed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > --- > v4->v5: > - Updated Kconfig description to include RZ/N2H SoC > - Grouped PM_* macros > - Made use of BIT() macro for PM_INPUT/OUTPUT > - Added necessary new lines for readability > - Dropped port_pins from struct rzt2h_pinctrl_data and > made use of rzt2h_gpio_names directly > - Added comment for mutex and lock in struct rzt2h_pinctrl > to clarify its use > - Replaced u16 to unsigned in rzt2h_pinctrl_write*/rzt2h_pinctrl_read* > - Updated rzt2h_validate_pin() to make used of BIT() macro instead of > open coding (1 << pin) > - Added consistent spacing around colons > - Inverted the logic to reduce indentation > - Updated if checks to use `reg & PM_OUTPUT/INPUT` instead of > `reg == PM_OUTPUT/INPUT` > - Dropped assigning drv_data for individual pins > - Opencoded devm_platform_ioremap_resource_byname() for "srs" resource > to avoid error message print as the resource is optional > - Replaced set_rv with set > - Added RZT2H_GET_BASE() macro and simplified > rzt2h_pinctrl_write*/rzt2h_pinctrl_read* macros > - Moved rzt2h_gpio_direction_output() below rzt2h_gpio_direction_input() > - Used consistent name ie reg64/reg16 in rzt2h_pinctrl_set_pfc_mode() Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-pinctrl for v6.18. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds