RE: [PATCH 3/5] media: renesas: fdp1: Convert to RUNTIME_PM_OPS()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: 09 July 2025 20:16
> To: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>; Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>;
> Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>; Kieran Bingham
> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>; Jacopo Mondi <jacopo@xxxxxxxxxx>; laurent.pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>
> Subject: [PATCH 3/5] media: renesas: fdp1: Convert to RUNTIME_PM_OPS()
> 
> Convert the Renesas Fine Display Processor driver from
> SET_RUNTIME_PM_OPS() to RUNTIME_PM_OPS() and pm_ptr().  This lets us
> drop the __maybe_unused annotations from its runtime suspend and resume
> callbacks, and reduces kernel size in case CONFIG_PM is disabled.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>

> ---
>  drivers/media/platform/renesas/rcar_fdp1.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
> index 5d453a7a89889fa3..a40e48a7078f11b6 100644
> --- a/drivers/media/platform/renesas/rcar_fdp1.c
> +++ b/drivers/media/platform/renesas/rcar_fdp1.c
> @@ -2409,7 +2409,7 @@ static void fdp1_remove(struct platform_device *pdev)
>  	rcar_fcp_put(fdp1->fcp);
>  }
> 
> -static int __maybe_unused fdp1_pm_runtime_suspend(struct device *dev)
> +static int fdp1_pm_runtime_suspend(struct device *dev)
>  {
>  	struct fdp1_dev *fdp1 = dev_get_drvdata(dev);
> 
> @@ -2418,7 +2418,7 @@ static int __maybe_unused fdp1_pm_runtime_suspend(struct device *dev)
>  	return 0;
>  }
> 
> -static int __maybe_unused fdp1_pm_runtime_resume(struct device *dev)
> +static int fdp1_pm_runtime_resume(struct device *dev)
>  {
>  	struct fdp1_dev *fdp1 = dev_get_drvdata(dev);
> 
> @@ -2429,9 +2429,7 @@ static int __maybe_unused fdp1_pm_runtime_resume(struct device *dev)
>  }
> 
>  static const struct dev_pm_ops fdp1_pm_ops = {
> -	SET_RUNTIME_PM_OPS(fdp1_pm_runtime_suspend,
> -			   fdp1_pm_runtime_resume,
> -			   NULL)
> +	RUNTIME_PM_OPS(fdp1_pm_runtime_suspend, fdp1_pm_runtime_resume, NULL)
>  };
> 
>  static const struct of_device_id fdp1_dt_ids[] = {
> @@ -2446,7 +2444,7 @@ static struct platform_driver fdp1_pdrv = {
>  	.driver		= {
>  		.name	= DRIVER_NAME,
>  		.of_match_table = fdp1_dt_ids,
> -		.pm	= &fdp1_pm_ops,
> +		.pm	= pm_ptr(&fdp1_pm_ops),
>  	},
>  };
> 
> --
> 2.43.0






[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux