RE: [PATCH 4/5] media: renesas: ceu: Convert to RUNTIME_PM_OPS()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: 09 July 2025 20:16
> To: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>; Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>;
> Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>; Kieran Bingham
> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>; Jacopo Mondi <jacopo@xxxxxxxxxx>; laurent.pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>
> Subject: [PATCH 4/5] media: renesas: ceu: Convert to RUNTIME_PM_OPS()
> 
> Convert the Renesas Capture Engine Unit driver from SET_RUNTIME_PM_OPS()
> to RUNTIME_PM_OPS() and pm_ptr().  This lets us drop the __maybe_unused
> annotations from its runtime suspend and resume callbacks, and reduces
> kernel size in case CONFIG_PM is disabled.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>

> ---
>  drivers/media/platform/renesas/renesas-ceu.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/renesas-ceu.c b/drivers/media/platform/renesas/renesas-
> ceu.c
> index 8cceafe491b1bec6..deed49d0fb10e0d7 100644
> --- a/drivers/media/platform/renesas/renesas-ceu.c
> +++ b/drivers/media/platform/renesas/renesas-ceu.c
> @@ -1048,7 +1048,7 @@ static int ceu_init_mbus_fmt(struct ceu_device *ceudev)
>  /*
>   * ceu_runtime_resume() - soft-reset the interface and turn sensor power on.
>   */
> -static int __maybe_unused ceu_runtime_resume(struct device *dev)
> +static int ceu_runtime_resume(struct device *dev)
>  {
>  	struct ceu_device *ceudev = dev_get_drvdata(dev);
>  	struct v4l2_subdev *v4l2_sd = ceudev->sd->v4l2_sd;
> @@ -1064,7 +1064,7 @@ static int __maybe_unused ceu_runtime_resume(struct device *dev)
>   * ceu_runtime_suspend() - disable capture and interrupts and soft-reset.
>   *			   Turn sensor power off.
>   */
> -static int __maybe_unused ceu_runtime_suspend(struct device *dev)
> +static int ceu_runtime_suspend(struct device *dev)
>  {
>  	struct ceu_device *ceudev = dev_get_drvdata(dev);
>  	struct v4l2_subdev *v4l2_sd = ceudev->sd->v4l2_sd;
> @@ -1709,15 +1709,13 @@ static void ceu_remove(struct platform_device *pdev)
>  }
> 
>  static const struct dev_pm_ops ceu_pm_ops = {
> -	SET_RUNTIME_PM_OPS(ceu_runtime_suspend,
> -			   ceu_runtime_resume,
> -			   NULL)
> +	RUNTIME_PM_OPS(ceu_runtime_suspend, ceu_runtime_resume, NULL)
>  };
> 
>  static struct platform_driver ceu_driver = {
>  	.driver		= {
>  		.name	= DRIVER_NAME,
> -		.pm	= &ceu_pm_ops,
> +		.pm	= pm_ptr(&ceu_pm_ops),
>  		.of_match_table = of_match_ptr(ceu_of_match),
>  	},
>  	.probe		= ceu_probe,
> --
> 2.43.0






[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux