Hi Geert,
On Wed, Jul 09, 2025 at 09:16:09PM +0200, Geert Uytterhoeven wrote:
> Convert the Renesas Fine Display Processor driver from
> SET_RUNTIME_PM_OPS() to RUNTIME_PM_OPS() and pm_ptr(). This lets us
> drop the __maybe_unused annotations from its runtime suspend and resume
> callbacks, and reduces kernel size in case CONFIG_PM is disabled.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/rcar_fdp1.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
> index 5d453a7a89889fa3..a40e48a7078f11b6 100644
> --- a/drivers/media/platform/renesas/rcar_fdp1.c
> +++ b/drivers/media/platform/renesas/rcar_fdp1.c
> @@ -2409,7 +2409,7 @@ static void fdp1_remove(struct platform_device *pdev)
> rcar_fcp_put(fdp1->fcp);
> }
>
> -static int __maybe_unused fdp1_pm_runtime_suspend(struct device *dev)
> +static int fdp1_pm_runtime_suspend(struct device *dev)
> {
> struct fdp1_dev *fdp1 = dev_get_drvdata(dev);
>
> @@ -2418,7 +2418,7 @@ static int __maybe_unused fdp1_pm_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int __maybe_unused fdp1_pm_runtime_resume(struct device *dev)
> +static int fdp1_pm_runtime_resume(struct device *dev)
> {
> struct fdp1_dev *fdp1 = dev_get_drvdata(dev);
>
> @@ -2429,9 +2429,7 @@ static int __maybe_unused fdp1_pm_runtime_resume(struct device *dev)
> }
>
> static const struct dev_pm_ops fdp1_pm_ops = {
> - SET_RUNTIME_PM_OPS(fdp1_pm_runtime_suspend,
> - fdp1_pm_runtime_resume,
> - NULL)
> + RUNTIME_PM_OPS(fdp1_pm_runtime_suspend, fdp1_pm_runtime_resume, NULL)
> };
>
> static const struct of_device_id fdp1_dt_ids[] = {
> @@ -2446,7 +2444,7 @@ static struct platform_driver fdp1_pdrv = {
> .driver = {
> .name = DRIVER_NAME,
> .of_match_table = fdp1_dt_ids,
> - .pm = &fdp1_pm_ops,
> + .pm = pm_ptr(&fdp1_pm_ops),
> },
> };
>
--
Regards,
Laurent Pinchart
