On Tue, Apr 29, 2025 at 10:16:08AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Collapse FIFO empty helper into a single return statement by removing the > redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make > `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y` > to improve readability without changing behavior. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 067c6af14e95..3d0810b3c35e 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -345,8 +345,6 @@ bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru) > amnfifopntr_w = amnfifopntr & AMnFIFOPNTR_FIFOWPNTR; > amnfifopntr_r_y = > (amnfifopntr & AMnFIFOPNTR_FIFORPNTR_Y) >> 16; > - if (amnfifopntr_w == amnfifopntr_r_y) > - return true; > > return amnfifopntr_w == amnfifopntr_r_y; > } -- Regards, Laurent Pinchart
