Hi Prabhakar, Thank you for the patch. On Tue, Apr 29, 2025 at 10:16:09AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Correct the misnamed FIFO-empty helper for the RZ/G3E CRU. Rename > `rz3e_fifo_empty` to `rzg3e_fifo_empty` to match the intended > naming convention. > > Reported-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Closes: https://lore.kernel.org/all/TY3PR01MB11346E57A3DF8D8A90A405E4686812@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 +- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 +- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > index 5fa73ab2db53..db27819d8200 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > @@ -366,7 +366,7 @@ static const struct rzg2l_cru_info rzg3e_cru_info = { > .irq_handler = rzg3e_cru_irq, > .enable_interrupts = rzg3e_cru_enable_interrupts, > .disable_interrupts = rzg3e_cru_disable_interrupts, > - .fifo_empty = rz3e_fifo_empty, > + .fifo_empty = rzg3e_fifo_empty, > .csi_setup = rzg3e_cru_csi2_setup, > }; > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > index c30f3b281284..56feda6e6207 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > @@ -199,7 +199,7 @@ void rzg3e_cru_enable_interrupts(struct rzg2l_cru_dev *cru); > void rzg3e_cru_disable_interrupts(struct rzg2l_cru_dev *cru); > > bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru); > -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru); > +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru); > void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, > const struct rzg2l_cru_ip_format *ip_fmt, > u8 csi_vc); > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 3d0810b3c35e..ab35caf97c51 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -323,7 +323,7 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, > return 0; > } > > -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru) > +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru) > { > u32 amnfifopntr = rzg2l_cru_read(cru, AMnFIFOPNTR); > -- Regards, Laurent Pinchart