On 14/08/2025 16:09, Inbaraj E wrote: > Document bindings for the FSD CSIS DMA controller. > > Signed-off-by: Inbaraj E <inbaraj.e@xxxxxxxxxxx> > --- > .../bindings/media/tesla,fsd-csis-media.yaml | 74 +++++++++++++++++++ Your patchset is organized in total mess. First clock, then media bindings, then arm64, then media drivers, then media bindings, then arm64... Please organize it in standard way - about independent subsystems I mentioned, so within media first bindings, then driver. Not intermixed. > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > diff --git a/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml b/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > new file mode 100644 > index 000000000000..ce6c2e58ed4e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/tesla,fsd-csis-media.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tesla FSD SoC MIPI CSI-2 DMA (Bridge device) receiver > + > +maintainers: > + - Inbaraj E <inbaraj.e@xxxxxxxxxxx> > + > +description: |- Drop |- > + The FSD MIPI CSI-2 (Camera Serial Interface 2) have internal DMA engine to > + capture frames originating from the sensor. > + > +properties: > + compatible: > + const: tesla,fsd-csis-media > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: aclk > + - const: pclk > + - const: pll > + > + iommus: > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port Don't you need second port to CSIS block? I guess this one is input from the sensor? > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - iommus > + - port Best regards, Krzysztof
