Hi Krzysztof, Thanks for the review. > > On 14/08/2025 16:09, Inbaraj E wrote: > > Document bindings for the FSD CSIS DMA controller. > > > > Signed-off-by: Inbaraj E <inbaraj.e@xxxxxxxxxxx> > > --- > > .../bindings/media/tesla,fsd-csis-media.yaml | 74 > > +++++++++++++++++++ > > Your patchset is organized in total mess. First clock, then media bindings, > then arm64, then media drivers, then media bindings, then arm64... Please > organize it in standard way - about independent subsystems I mentioned, so > within media first bindings, then driver. Not intermixed. I'll update in next patchset. > > > > > 1 file changed, 74 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > b/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > new file mode 100644 > > index 000000000000..ce6c2e58ed4e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/tesla,fsd-csis- > media.yam > > +++ l > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=21cb70d9-4129ed84-21cafb96- > 000b > > +abd9f1ba-63c99c5193b8964e&q=1&e=f7087d49-8d33-4468-9323- > 67fa9fa72e40& > > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fmedia%2Ftesla%2Cfsd- > csis-me > > +dia.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=4db8909d-2d5a0dc0-4db91bd2- > 000b > > +abd9f1ba-be3588ecc45596c1&q=1&e=f7087d49-8d33-4468-9323- > 67fa9fa72e40& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Tesla FSD SoC MIPI CSI-2 DMA (Bridge device) receiver > > + > > +maintainers: > > + - Inbaraj E <inbaraj.e@xxxxxxxxxxx> > > + > > +description: |- > > Drop |- > > > + The FSD MIPI CSI-2 (Camera Serial Interface 2) have internal DMA > > + engine to capture frames originating from the sensor. > > + > > +properties: > > + compatible: > > + const: tesla,fsd-csis-media > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: aclk > > + - const: pclk > > + - const: pll > > + > > + iommus: > > + maxItems: 1 > > + > > + port: > > + $ref: /schemas/graph.yaml#/properties/port > > Don't you need second port to CSIS block? No, one port is sufficient. This port represent CSIS DMA and connected to CSIS (imx-mipi-csis node) I guess this one is input from the > sensor? No, it is input from CSIS(imx-mipi-csis). Regards, Inbaraj E
