On 29/08/2025 15:56, Varada Pavani wrote: > FSD SoC WDT has few changes when compared to exynos7 interms of Clocks, > PMU register bits for each cluster. So use "tesla,fsd-wdt" So what was added in 2022? > compatibility for using correct driver data. > FSD supports 2 Clocks for WDT (PCLK and CLK). > - use fin_pll source Clock for all timer related calculations. > - use bus Clock (IMEM_WDT0_IPCLKPORT_PCLK) to gate/ungate the register > interface. Update both as per WDT UM. No, you break all the users. Probably users don't care, but I do care because I use that arguments for reviewing other patches, so I apply a bit stricter rules for existing Samsung trees. Otherwise provide rationale about impact and what was happening in 2022 with this code... Best regards, Krzysztof
