On 11/08/2025 17:46, Shradha Todi wrote: > The current Exynos PCIe yaml binding file is hard to reuse by > other Samsung SoCs. Refactoring it by: > - Moving common Samsung PCIe properties into samsung,exynos-pcie.yaml > - Creating a dedicated samsung,exynos5433-pcie.yaml file for properties > and constraints specific to the Exynos5433 SoC > > Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> > --- > .../bindings/pci/samsung,exynos-pcie.yaml | 70 +-------------- > .../bindings/pci/samsung,exynos5433-pcie.yaml | 89 +++++++++++++++++++ > 2 files changed, 91 insertions(+), 68 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5433-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > index f20ed7e709f7..fd0b97b30821 100644 > --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > @@ -11,7 +11,7 @@ maintainers: > - Jaehoon Chung <jh80.chung@xxxxxxxxxxx> > > description: |+ > - Exynos5433 SoC PCIe host controller is based on the Synopsys DesignWare > + Samsung SoCs PCIe host controller is based on the Synopsys DesignWare > PCIe IP and thus inherits all the common properties defined in > snps,dw-pcie.yaml. > > @@ -19,9 +19,6 @@ allOf: > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > properties: > - compatible: > - const: samsung,exynos5433-pcie > - > reg: > items: > - description: Data Bus Interface (DBI) registers. So the only common part left here is reg and phy? I don't think such common file brings any value. Best regards, Krzysztof
