Hi Krzysztof, On Thu, 2025-04-10 at 08:18 +0200, Krzysztof Kozlowski wrote: > On Wed, Apr 09, 2025 at 09:37:21PM GMT, André Draszik wrote: > > This series adds initial support for the Samsung S2MPG10 PMIC using the > > MFD framework. This is a PMIC for mobile applications and is used on > > the Google Pixel 6 and 6 Pro (oriole / raven). > > > > *** dependency note *** > > > > To compile, this depends on the Samsung ACPM driver in Linux next with > > Are you sure these are build time dependencies? Do not look like. Yes, there is a build time dependency on the ACPM driver (also mentioned in Kconfig). In particular the last series mentioned below (acpm-children) adds devm_acpm_get_by_node() which this driver needs. > Also, > if they are, the patchset will wait for quite some time. All the dependencies appear to have landed in linux-next as of writing this. > > > the following additional patches: > > https://lore.kernel.org/all/20250324-acpm-atomic-v2-0-7d87746e1765@xxxxxxxxxx/ > > https://lore.kernel.org/all/20250319-acpm-fixes-v2-0-ac2c1bcf322b@xxxxxxxxxx/ > > https://lore.kernel.org/all/20250327-acpm-children-v1-0-0afe15ee2ff7@xxxxxxxxxx/ > > > > *** dependency note end *** > > > > +++ Kconfig update +++ > > > > There is a Kconfig symbol update in this series, because the existing > > Samsung S2M driver has been split into core and transport (I2C & ACPM) > > parts. CONFIG_MFD_SEC_CORE is now truly a core driver, and > > the I2C code that was part of it is now enabled via CONFIG_MFD_SEC_I2C. > > > > This was necessary because unlike the other S2M PMICs, S2MPG10 doesn't > > talk via I2C, but via the Samsung ACPM firmware. > > > > +++ Kconfig update end +++ > > > > This series must be applied in-order, due to interdependencies of some > > of the patches. There are also various cleanup patches to the S2M > > drivers. I've kept them ordered as: > > They should not depend... although actually not my trees, except the > firmware. The s2mpg10 core patch adds enums and register macros for the new PMIC, which the clk and rtc drivers then use, hence I'm calling out this dependency - they can not compile without the core patch in place. Cheers, Andre'
