On Mon, Apr 28, 2025 at 05:44:21PM +0530, Faraz Ata wrote: > HI Greg > > > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports > > > > On Thu, Apr 17, 2025 at 11:02:24AM +0530, Faraz Ata wrote: > > > Hello Krzysztof > > > > > > > -----Original Message----- > > > > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > > Sent: Thursday, April 17, 2025 10:50 AM > > > > To: Faraz Ata <faraz.ata@xxxxxxxxxxx>; alim.akhtar@xxxxxxxxxxx; > > > > gregkh@xxxxxxxxxxxxxxxxxxx; jirislaby@xxxxxxxxxx > > > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung- > > > > soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > > > > serial@xxxxxxxxxxxxxxx; dev.tailor@xxxxxxxxxxx; > > > > rosa.pila@xxxxxxxxxxx > > > > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart > > > > ports > > > > > > > > On 17/04/2025 06:34, Faraz Ata wrote: > > > > > ExynosAutov920 SoC supports 18 UART ports, update the value of > > > > UART_NR > > > > > to accommodate the same. > > > > > > > > > > Signed-off-by: Faraz Ata <faraz.ata@xxxxxxxxxxx> > > > > > --- > > > > > Changes in v3: > > > > > - Fixed review comments from Krzysztof > > > > > > > > Which ones? What changed? > > > > > > > While sending v2 change log was missed unintentionally. > > > Added missed change log in v3. > > > > Can you add this properly and send a v4? > > > This was a clarification given to Krzysztof. > The complete change-log was missed in v2, This was pointed out by Krzysztof. > Added those missed changes in v3. > Do you want me to add this clarification as well and send v4 ? Yes please.