Hi Wolfram,
CC Fabrizio
On Mon, 14 Apr 2025 at 13:12, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> The intention of this series is to enable the UART attached to the
> 9-pin-SubD connector on the extentsion board (patch 2). I got confused
> while doing this, because currently the uarts are counted from 0 in the
> SoC DTSI while they start from 1 in the documentation and the
> schematics. Thus, patch 1 renames the labels accordingly. However, the
> series is still RFC because I am calling for opinions if we maybe also
> want to fix the pinmux defines like this one 'RZN1_FUNC_UART2? to the
> official numbering?
The pinmux definitions in include/dt-bindings/pinctrl/rzn1-pinctrl.h are
ABI, so we cannot change them.
If we only renumber the UARTs in the DT, we end up with a mix,
which is even more confusing:
pins_uart3: pins_uart3 {
pinmux = <RZN1_PINMUX(105, RZN1_FUNC_UART2)>,
<RZN1_PINMUX(106, RZN1_FUNC_UART2)>,
<RZN1_PINMUX(107, RZN1_FUNC_UART2)>,
<RZN1_PINMUX(108, RZN1_FUNC_UART2)>;
bias-disable;
};
So I am in favour of not renumbering the UARTs.
BTW, the RZ/N1 CD contains a webapp (Toosl/PinMux/index.html)
to generate pinmux DTS, but it uses (a) different properties and
macros than upstream, and (b) the numbering from the documentation
(i.e. UART1-8), so people cannot use it with upstream anyway.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
