Re: [PATCH 4/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe LEDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Fri, 11 Apr 2025 at 13:40, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > These are called LED1-LED8 in the Board Setup Notes.
>
> Oh, where? I have a version from "Dec 14, 2020" which only calls them
> Software-LEDs or "Port0 BitX". Schematics call them DBG_LEDx. I don't
> care much. The "db" board has a "USER LED2", as long as we don't
> conflict with that name, I am fine.
>
> >     color = <LED_COLOR_ID_ORANGE>;
>
> Hmmm, they are definitely GREEN here.
>
> >     function = LED_FUNCTION_INDICATOR;
>
> LED_FUNCTION_PROGRAMMING?
>
> > Perhaps you want the first one to be a heartbeat?
> >
> >     linux,default-trigger = "heartbeat";
>
> I recently removed a default-trigger on another board because it was in
> the way. So, I'd rather not.
>
> Phew, starting with the PHY LEDs on this board, didn't know LED were so
> troublesome...
>
> Shall I resend only this patch and rebased on the keyboard patch? Or
> resend the both?

Please just resend a new version of this patch.
I have applied all your other RZ/N1 patches that arrived before the
weekend. Please check renesas-next or -devel.
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux