Re: [PATCH 4/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe LEDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Fri, 28 Mar 2025 at 16:33, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> @@ -24,6 +25,42 @@ chosen {
>         aliases {
>                 serial0 = &uart0;
>         };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               led-pca0 {

These are called LED1-LED8 in the Board Setup Notes.

> +                       gpios = <&pca9698 0 GPIO_ACTIVE_HIGH>;
> +               };

Missing:

    color = <LED_COLOR_ID_ORANGE>;
    function = LED_FUNCTION_INDICATOR;

Perhaps you want the first one to be a heartbeat?

    linux,default-trigger = "heartbeat";

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux