Hi Wolfram,
On Fri, 11 Apr 2025 at 11:54, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> This board only connects two LEDs instead of three. Also, give them
> descriptions to avoid namespace collusions.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> @@ -6,6 +6,7 @@
> *
> */
>
> +#include <dt-bindings/leds/common.h>
> #include "r9a06g032-rzn1d400-db.dts"
>
> / {
> @@ -102,15 +103,18 @@ switch0phy1: ethernet-phy@1 {
> leds {
> #address-cells = <1>;
> #size-cells = <0>;
> -
> led@0 {
> reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_LAN;
> + default-state = "keep";
> };
> +
> led@1 {
> reg = <1>;
> - };
> - led@2 {
> - reg = <2>;
> + color = <LED_COLOR_ID_RED>;
Can you please confirm they are RED and not ORANGE, as documented in
the schematics?
> + function = LED_FUNCTION_ACTIVITY;
> + default-state = "keep";
> };
> };
> };
LGTM, will squash into "[PATCH v4] ARM: dts: r9a06g032: add
r9a06g032-rzn1d400-eb board device-tree" when the above is confirmed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
