Hi Wolfram, On Fri, 11 Apr 2025 at 11:53, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > > + pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, > > > + <&pins_mdio1>; > > > + > > > + mdio { > > > + /* CN15 and CN16 switches must be configured in MDIO2 mode */ > > > + switch0phy1: ethernet-phy@1 { > > > + reg = <1>; > > > + leds { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + led@0 { > > > + reg = <0>; > > > > color = <LED_COLOR_ID_GREEN>; > > > > > + }; > > > + led@1 { > > > + reg = <1>; > > > > color = <LED_COLOR_ID_ORANGE>; > > > > > + }; > > > > The above should also have one of: > > > > function = LED_FUNCTION_LAN; > > function = LED_FUNCTION_SPEED_LAN; > > > > I don't know the LED function mapping. > > I have an incremental fix for the LEDs to this patch. Thomas cannot > really do it because he doesn't have the board. I was waiting with my > patch until this patch is upstream, but I better send it out now, so you > can squash it into this one? Yes please.This patch is becoming too much of a dependency. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds