Hi Wolfram, On Fri, 28 Mar 2025 at 16:33, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > To match the documentation and schematics, they are numbered from 1 and > not from 0. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v6.16. > --- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi > +++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi > @@ -268,6 +268,28 @@ uart7: serial@50004000 { > status = "disabled"; > }; > > + i2c1: i2c@40063000 { > + #address-cells = <1>; > + #size-cells = <0>; I will move these below while applying, as per Documentation/devicetree/bindings/dts-coding-style.rst. > + compatible = "renesas,r9a06g032-i2c", "renesas,rzn1-i2c", "snps,designware-i2c"; > + reg = <0x40063000 0x100>; > + interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&sysctrl R9A06G032_HCLK_I2C0>, <&sysctrl R9A06G032_CLK_I2C0>; > + clock-names = "ref", "pclk"; > + status = "disabled"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds