Re: [RFC PATCH 2/4] ARM: dts: renesas: r9a06g032: add second clock input to RTC

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

On Thu, 13 Mar 2025 at 11:25, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> The external rtc clock is populated on the RZ/N1D module, so describe it
> and add a reference to the RTC node.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> For the non-RFC series, it makes probably sense to split this patch into
> two.

Indeed.

> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> @@ -47,6 +47,10 @@ &eth_miic {
>         renesas,miic-switch-portin = <MIIC_GMAC2_PORT>;
>  };
>
> +&ext_rtc_clk {
> +       clock-frequency = <32768>;
> +};

That's the mighty 0.033 MHz crystal X2_1? ;-)

This change is good for sure.

> +
>  &gmac2 {
>         status = "okay";
>         phy-mode = "gmii";
> diff --git a/arch/arm/boot/dts/renesas/r9a06g032.dtsi b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
> index 7548291c8d7e..458dab9d3b7f 100644
> --- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi
> +++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
> @@ -73,8 +73,8 @@ rtc0: rtc@40006000 {
>                                      <GIC_SPI 67 IRQ_TYPE_EDGE_RISING>,
>                                      <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
>                         interrupt-names = "alarm", "timer", "pps";
> -                       clocks = <&sysctrl R9A06G032_HCLK_RTC>;
> -                       clock-names = "hclk";
> +                       clocks = <&sysctrl R9A06G032_HCLK_RTC>, <&ext_rtc_clk>;
> +                       clock-names = "hclk", "xtal";

This depends on whether we decide to provide direct access to ext_rtc_clk,
or through the system controller's clock provider.

>                         power-domains = <&sysctrl>;
>                         status = "disabled";
>                 };

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds