Hi Thierry, On Mon, 31 Mar 2025 at 15:55, Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx> wrote: > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > On Mon, 31 Mar 2025 at 14:27, Thierry Bultel > > <thierry.bultel.yh@xxxxxxxxxxxxxx> wrote: > > > The SCI of RZ/T2H SoC (a.k.a r9a09g077), as a lot > > > > RSCI in the RZ/T2H SoC ... has > > > > > of similarities with other Renesas SoC like G2L, G3S, V2L; > > > > ... with SCI in other .. > > > > > However, it has a different set of registers, and in addition to > > > serial, this IP also supports SCIe (encoder), SmartCard, i2c and spi. > > > This is why the 'renesas,sci' fallback for generic SCI does not apply > > for it. > > > > > > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > > > Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx> > > > > > --- a/Documentation/devicetree/bindings/serial/renesas,sci.yaml > > > +++ b/Documentation/devicetree/bindings/serial/renesas,sci.yaml > > > > Given we're now using the "RSCI" naming, I think it deserves its own DT > > binding document. > > All right, but I have then several questions > 1) I am not sure it can have generic fallback, > e.g. something like : > > properties: > compatible: > - const: renesas,r9a09g077-rsci # RZ/T2H > > ... is just enough, can you confirm ? I don't think we need a generic fallback at this point. You didn't have one before. > 2) Should I also change the node name in .dtsi file from 'sci0' to 'rsci0' ? You mean the labels? The node name is always "serial". I think keeping sci0 for the label is fine, as that matches the name of the instance in the documentation. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds