Hi Geert,
Thank you for the review.
On Mon, Aug 18, 2025 at 2:35 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 22:03, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Add pinctrl for SCI0 node.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > @@ -5,6 +5,8 @@
> > * Copyright (C) 2025 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/pinctrl/renesas,r9a09g077-pinctrl.h>
>
> This relies on RZT2H_PORT_PINMUX() == RZN2H_PORT_PINMUX.
> So perhaps it is best to get rid of the latter, and always use the former?
>
Ok makes sense, I'll drop the RZN2H_* macro definitions from patch
04/13 and use RZT2H_* macros for RZ/N2H.
Cheers,
Prabhakar
> > +
> > / {
> > aliases {
> > serial0 = &sci0;
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v6.18.
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
