Hi Geert, Thanks for the patch. > -----Original Message----- > From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Sent: 22 August 2025 11:17 > Subject: [PATCH v2 11/11] can: rcar_can: Convert to %pe > > Replace numerical error codes by mnemotechnic error codes, to improve the user experience in case of > errors. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> Cheers, Biju > --- > v2: > - New. > --- > drivers/net/can/rcar/rcar_can.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c index > 51bf8f7e71824ac8..5f85f4e272054789 100644 > --- a/drivers/net/can/rcar/rcar_can.c > +++ b/drivers/net/can/rcar/rcar_can.c > @@ -521,20 +521,20 @@ static int rcar_can_open(struct net_device *ndev) > } > err = clk_prepare_enable(priv->can_clk); > if (err) { > - netdev_err(ndev, "failed to enable CAN clock, error %d\n", > - err); > + netdev_err(ndev, "failed to enable CAN clock: %pe\n", > + ERR_PTR(err)); > goto out_rpm; > } > err = open_candev(ndev); > if (err) { > - netdev_err(ndev, "open_candev() failed, error %d\n", err); > + netdev_err(ndev, "open_candev() failed %pe\n", ERR_PTR(err)); > goto out_can_clock; > } > napi_enable(&priv->napi); > err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev); > if (err) { > - netdev_err(ndev, "request_irq(%d) failed, error %d\n", > - ndev->irq, err); > + netdev_err(ndev, "request_irq(%d) failed %pe\n", ndev->irq, > + ERR_PTR(err)); > goto out_close; > } > rcar_can_start(ndev); > @@ -786,8 +786,8 @@ static int rcar_can_probe(struct platform_device *pdev) > } > priv->can_clk = devm_clk_get(dev, clock_names[clock_select]); > if (IS_ERR(priv->can_clk)) { > + dev_err(dev, "cannot get CAN clock: %pe\n", priv->can_clk); > err = PTR_ERR(priv->can_clk); > - dev_err(dev, "cannot get CAN clock, error %d\n", err); > goto fail_clk; > } > > @@ -813,7 +813,7 @@ static int rcar_can_probe(struct platform_device *pdev) > > err = register_candev(ndev); > if (err) { > - dev_err(dev, "register_candev() failed, error %d\n", err); > + dev_err(dev, "register_candev() failed %pe\n", ERR_PTR(err)); > goto fail_rpm; > } > > -- > 2.43.0 >