Hi Jonathan,
On Mon, Aug 25, 2025 at 04:00:23PM +0100, Jonathan Cameron wrote:
> > @@ -95,18 +95,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
> > if (en && dac->common->hfsel)
> > udelay(1);
> >
> > - if (!enable) {
> > - pm_runtime_mark_last_busy(dev);
> > - pm_runtime_put_autosuspend(dev);
> > - }
> > -
> > - return 0;
> > -
> > -err_put_pm:
> > - if (enable) {
> > - pm_runtime_mark_last_busy(dev);
> > - pm_runtime_put_autosuspend(dev);
> > - }
> > +err_pm_put:
> > + pm_runtime_put_autosuspend(dev);
>
> now the put is here, whether or not there was ever a get as the get is
> gated on enable()
Oops. I'll fix this in v4, with just this patch as the rest are merged.
--
Regards,
Sakari Ailus
