On Wed, Aug 27, 2025 at 11:34:09PM +0000, Kuninori Morimoto wrote:
> Document the compatible values for the Renesas R-Car X5H (R8A78000) SoC
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> v1 -> v2
> - add empty enum to avoid allowing invalid use.
I don't understand why do you need this. Where is any user of it? There
is no such in this patchset, so this must be explicitly explained in the
commit msg.
>
> Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index 5f9d541d177a..e2fec2afbc6d 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -473,6 +473,12 @@ properties:
> - const: renesas,r8a779mb
> - const: renesas,r8a7795
>
> + - description: R-Car X5H (R8A78000)
> + items:
> + - enum:
> + - {} # avoid allowing invalid use. will be replaced to actual board name
We don't allow such cases because it is pointless.
Otherwise explain in the commit msg why this is needed, why exception is
justified.
You have entire commit msg to explain anything unusual and if you look
at source code you will not notice such syntax for boards, so clearly
this is unusual.
Best regards,
Krzysztof
