Re: [PATCH v2] dt-bindings: soc: renesas: Document R-Car X5H

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof, Conor, Geert

> > > v1 -> v2
> > > 	- add empty enum to avoid allowing invalid use.
> > 
> > I don't understand why do you need this. Where is any user of it? There
> > is no such in this patchset, so this must be explicitly explained in the
> > commit msg.
(snip)
> > We don't allow such cases because it is pointless.
> > 
> > Otherwise explain in the commit msg why this is needed, why exception is
> > justified.
> > 
> > You have entire commit msg to explain anything unusual and if you look
> > at source code you will not notice such syntax for boards, so clearly
> > this is unusual.
> 
> They have a soc driver that binds to the compatible, which is why I
> suggested this rather than refusing the patch. I do agree it should be
> mentioned though.

OK, let's skip this patch and post it with both SoC and Board name.
Which was my original plan.


Thank you for your help !!

Best regards
---
Kuninori Morimoto




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux