Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Prabhakar <prabhakar.csengg@xxxxxxxxx>
Subject: Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
From: Andrew Lunn <andrew@xxxxxxx>
Date: Thu, 4 Sep 2025 22:55:41 +0200
Cc: Clément Léger <clement.leger@xxxxxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, linux-renesas-soc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Biju Das <biju.das.jz@xxxxxxxxxxxxxx>, Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>, Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
In-reply-to: <20250904114204.4148520-9-prabhakar.mahadev-lad.rj@bp.renesas.com>
References: <20250904114204.4148520-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20250904114204.4148520-9-prabhakar.mahadev-lad.rj@bp.renesas.com>

> -static void miic_reg_writel(struct miic *miic, int offset, u32 value)
> +static inline void miic_unlock_regs(struct miic *miic)
> +{

Please don't use inline in C files. The compiler should decide.

       Andrew

Follow-Ups:
- Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
  - From: Lad, Prabhakar

References:
- [PATCH net-next v2 0/9] Add PCS support for Renesas RZ/{T2H,N2H} SoCs
  - From: Prabhakar
- [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
  - From: Prabhakar

Prev by Date: Re: [PATCH] drm/panel: ilitek-ili9881c: Turn ILI9881C_COMMAND_INSTR() parameters lowercase
Next by Date: Re: [PATCH net-next v2 9/9] net: pcs: rzn1-miic: Add RZ/T2H MIIC support
Previous by thread: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
Next by thread: Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]