Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrew Lunn <andrew@xxxxxxx>
Subject: Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
Date: Fri, 5 Sep 2025 12:48:37 +0100
Cc: Clément Léger <clement.leger@xxxxxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, linux-renesas-soc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Biju Das <biju.das.jz@xxxxxxxxxxxxxx>, Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>, Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
In-reply-to: <fc103af7-0558-46bf-a668-d4d815ae704e@lunn.ch>
References: <20250904114204.4148520-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20250904114204.4148520-9-prabhakar.mahadev-lad.rj@bp.renesas.com> <fc103af7-0558-46bf-a668-d4d815ae704e@lunn.ch>

Hi Andrew,

Thank you for the review.

On Thu, Sep 4, 2025 at 9:55 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > -static void miic_reg_writel(struct miic *miic, int offset, u32 value)
> > +static inline void miic_unlock_regs(struct miic *miic)
> > +{
>
> Please don't use inline in C files. The compiler should decide.
>
Ok, I will drop this in the next version.

Cheers,
Prabhakar

References:
- [PATCH net-next v2 0/9] Add PCS support for Renesas RZ/{T2H,N2H} SoCs
  - From: Prabhakar
- [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
  - From: Prabhakar
- Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
  - From: Andrew Lunn

Prev by Date: Re: [PATCH] PCI: endpoint: pci-epf-test: Limit PCIe BAR size for fixed BARs
Next by Date: Re: [PATCH net-next v2 9/9] net: pcs: rzn1-miic: Add RZ/T2H MIIC support
Previous by thread: Re: [PATCH net-next v2 8/9] net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
Next by thread: [PATCH net-next v2 5/9] net: pcs: rzn1-miic: move port range handling into SoC data
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]