Hi Laurent,
On Thu, 4 Sept 2025 at 17:25, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 01, 2025 at 04:06:57PM +0200, Niklas Söderlund wrote:
> > On 2025-09-01 16:03:49 +0200, Geert Uytterhoeven wrote:
> > > On Thu, 28 Aug 2025 at 00:15, Niklas Söderlund wrote:
> > > > Add an overlay to connect an IMX219 camera sensor to the J1 connector.
> > > > The IMX219 utilizes 2 CSI-2 D-PHY lanes. This enables the video capture
> > > > pipeline behind the CSI40 Rx to be enabled to process images from the
> > > > sensor.
> > > >
> > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > > > ---
> > > > * Changes since v3
> > > > - Use correct port@0 instead of port.
> > >
> > > Thanks for the update!
> > >
> > > > --- a/arch/arm64/boot/dts/renesas/Makefile
> > > > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > > > @@ -96,7 +96,10 @@ dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g2-white-hawk-single-ard-audio-da7212.dtb
> > > >
> > > > DTC_FLAGS_r8a779g3-sparrow-hawk += -Wno-spi_bus_bridge
> > > > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk.dtb
> > > > +dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk-camera-j1-imx219.dtbo
> > > > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk-fan-pwm.dtbo
> > > > +r8a779g3-sparrow-hawk-camera-j1-imx219-dtbs := r8a779g3-sparrow-hawk.dtb r8a779g3-sparrow-hawk-camera-j1-imx219.dtbo
> > > > +dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk-camera-j1-imx219.dtb
> > > > r8a779g3-sparrow-hawk-fan-pwm-dtbs := r8a779g3-sparrow-hawk.dtb r8a779g3-sparrow-hawk-fan-pwm.dtbo
> > > > dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g3-sparrow-hawk-fan-pwm.dtb
> > >
> > > Usually we keep the related parts together, but we indeed already have
> > > one case of interleaving. I am not sure which style is best...
> >
> > I have no real preference. The style here is only me trying to mimic
> > what I seen elsewhere in the file. Want me to switch to the other style?
>
> I don't mind much either way either. The patch series looks good to me,
> I think it can be merged once we decide on a style.
Let's settle on the prevalent existing style? Keeping things together
reduces conflicts when multiple patches adding overlays are in-flight.
And of course we have Marek's outstanding comments (no underscores in
node names, no need for "reg_"-prefixes in regulator names).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
