Re: [PATCH v2 4/4] arm64: renesas: Add R8A78000 Ironhide board code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

Thanks for your patch!

One-line summary should be e.g. "arm64: dts: renesas: r8a78000: Add
initial Ironhide support".

On Wed, 10 Sept 2025 at 04:02, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Hai Pham <hai.pham.ud@xxxxxxxxxxx>
>
> Add the initial support for Renesas R8A7800 board code.

board code?

>
> [Kuninori: tidyup for upstreaming]
>
> Signed-off-by: Hai Pham <hai.pham.ud@xxxxxxxxxxx>
> Signed-off-by: Vinh Nguyen <vinh.nguyen.xz@xxxxxxxxxxx>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> Signed-off-by: Khanh Le <khanh.le.xr@xxxxxxxxxxx>
> Signed-off-by: Huy Bui <huy.bui.wm@xxxxxxxxxxx>
> Signed-off-by: Phong Hoang <phong.hoang.wz@xxxxxxxxxxx>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -182,3 +182,5 @@ dtb-$(CONFIG_ARCH_R9A09G057) += r9a09g057h48-kakip.dtb
>
>  dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo
>  dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo
> +
> +dtb-$(CONFIG_ARCH_R8A78000) += r8a78000-ironhide.dtb

Please insert this after the last R8A77* line, and before the first
R9A* line.

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts

> +       chosen {
> +               bootargs = "maxcpus=1"; /* FIXME */

I'd rather drop all CPU nodes except for the first from r8a78000.dtsi.
They can be added later, when SMP works.

> +               stdout-path = "serial0:1843200n8";
> +       };
> +
> +       memory@60600000 {
> +               device_type = "memory";
> +               /* first 518MB is reserved for other purposes. */

MiB

(0x20600000 = ca. 543.2 MB ;-)

> +               reg = <0x0 0x60600000 0x0 0x5fa00000>;
> +       };

> +&extal_clk {
> +       clock-frequency = <16666666>;

Schematics says 16666600 Mhz (accuracy is only 50ppm anyway).

> +};

> +&hscif0 {
> +       uart-has-rtscts;
> +       /* Please use exclusively to the scif0 node */

Please drop this comment, as there is no scif0 node yet in this file.

> +       status = "okay";
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux